Fix flaky Clique tests waiting for nodes to be fully connected and in sync#7993
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Dec 5, 2024
Merged
Fix flaky Clique tests waiting for nodes to be fully connected and in sync#7993fab-10 merged 2 commits intobesu-eth:mainfrom
fab-10 merged 2 commits intobesu-eth:mainfrom
Conversation
fab-10
force-pushed
the
fix-flaky-clique-at
branch
2 times, most recently
from
069a8ef to
9a56df7
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
fix-flaky-clique-at
branch
from
9a56df7 to
38e47cc
Compare
fab-10
changed the title
macfarla
approved these changes
Dec 5, 2024
This was referenced Dec 6, 2024
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
…th#7993) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
verify nodes are fully connected otherwise blocks could not be propagated
Fixed Issue(s)
#7992
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests